Re: [PATCH v2 08/21] ASoC: card: Let 'fixup_controls' return errors

[James Calligeros]

On Thursday, 8 October 2026 12:23:42 am Australian Eastern Standard Time 
Charles Keepax wrote:
> On Sun, Oct 04, 2026 at 04:03:35PM +1000, James Calligeros wrote:
> > From: Martin Povišer <povik+lin@xxxxxxxxxxx>
> > 
> > Let the 'fixup_controls' card method return error values which will roll
> > back the half-done binding of the card.
> > 
> > Signed-off-by: Martin Povišer <povik+lin@xxxxxxxxxxx>
> > Signed-off-by: James Calligeros <jcalligeros99@xxxxxxxxx>
> > ---
> > 
> >  include/sound/soc-card.h                 |  2 +-
> >  include/sound/soc.h                      |  2 +-
> >  .../soc/mediatek/mt8188/mt8188-mt6359.c  |  4 +++-
> >  sound/soc/soc-card.c                     | 12 +++++++++---
> >  sound/soc/soc-core.c                     |  5 ++++-
> 
> Fixup is missing here for sound/soc/sdca/sdca_class_function.c

Unless I'm missing something, that one calls the .fixup_controls on
snd_soc_component_driver, which is not the snd_soc_card callback
modified by this commit. That callback already expected an int,
and class_function_component_fixup_controls already returns one
per b8f71f16134f ("ASoC: SDCA: Switch to fixup_controls callback
for IRQ registration").

Regards,
James