Re: [PATCH v4] staging: greybus: replace PTR_ERR() with %pe in error messages

[Greg KH]

On Sat, Oct 17, 2026 at 07:15:57PM +0530, Yalagada Pavan Kumar wrote:
> On Sat, Oct 17, 2026 at 01:20:39PM +0200, Greg KH wrote:
> > On Thu, Oct 15, 2026 at 01:52:38PM +0530, pavankumaryalagada@xxxxxxxxx wrote:
> > > From: Yalagada Pavan Kumar <pavankumaryalagada@xxxxxxxxx>
> > > 
> > > Use %pe to print error pointers directly and display their
> > > error names.
> > > 
> > > Keep PTR_ERR() calls when the numeric error value is needed
> > > for returning the error code.
> > > 
> > > Signed-off-by: Yalagada Pavan Kumar <pavankumaryalagada@xxxxxxxxx>
> > > ---
> > > v4:
> > > - Return error codes directly instead of storing them in ret,
> > >   as suggested by Julia Lawall.
> > > - Remove the unused ret variable.
> > 
> > 
> > Hi,
> > 
> > This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
> > a patch that has triggered this response.  He used to manually respond
> > to these common problems, but in order to save his sanity (he kept
> > writing the same thing over and over, yet to different people), I was
> > created.  Hopefully you will not take offence and will fix the problem
> > in your patch and resubmit it so that it can be accepted into the Linux
> > kernel tree.
> > 
> > You are receiving this message because of the following common error(s)
> > as indicated below:
> > 
> > - Your patch did not apply to any known trees that Greg is in control
> >   of.  Possibly this is because you made it against Linus's tree, not
> >   the linux-next tree, which is where all of the development for the
> >   next version of the kernel is at.  Please refresh your patch against
> >   the linux-next tree, or even better yet, the development tree
> >   specified in the MAINTAINERS file for the subsystem you are submitting
> >   a patch for, and resend it.
> 
> This v4 patch did not apply because arche-apb-ctrl.c and arche-platform.c
> were removed by commit 2f75b2eac999.
> 
> The fw-core.c changes from my earlier v1 patch present in staging/staging-next.
> 
> Only the change to uart.c remains.
> 
> Should i send a v5 containing only the remaining change in uart.c?

If you wish to see this patch applied, yes.

> Also, should i keep Alex Elder's Reviewed-by tag in v5?

If the only change is removal of other parts of the patch, yes.

thanks,

greg k-h