Re: [PATCH net-next v2 02/11] net: ethernet: qualcomm: ppe: Fix multicast queue config table access

[Simon Horman]

On Wed, Oct 14, 2026 at 03:20:53PM +0800, Jie Luo wrote:
> 
> 
> On 10/12/2026 9:03 PM, netdev-bot+sashiko@xxxxxxxxxx wrote:
> >> Fix it by converting the queue ID to the index of the multicast queue
> >> configuration table and accessing only the 3 words of the entry.
> >>
> >> Signed-off-by: Luo Jie <jie.luo@xxxxxxxxxxxxxxxx>
> > [Severity: Low]
> > Should this have a Fixes: tag? Commit 806268dc7efd added both the
> > multicast_queue_cfg[5] declaration and the absolute queue_id indexing:
> > 
> > Fixes: 806268dc7efd ("net: ethernet: qualcomm: Initialize PPE queue management for IPQ9574")
> > 
> > ipq9574_ppe_qm_queue_config[] covers multicast queues 256 to 299. That
> > means kernels which already have the IPQ9574 PPE QM code take the broken
> > else branch in ppe_config_qm() on every probe.
> > 
> > Since this fixes code that is already merged, could it be sent on its
> > own to net with the Fixes: tag, rather than as part of the IPQ5424
> > series?
> 
> The IPQ5424 QM configuration in this series depends on this fix. The
> issue is only theoretical: it was found by code inspection, and no
> user has reported it. So we would like to keep this patch in this series
> for net-next, without the Fixes: tag.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>