Re: [PATCH] vfs: keep the mount pinned while waiting for a parent delegation break

[Christian Brauner]

On Fri, Oct 16, 2026 at 07:38:45PM +0100, Al Viro wrote:
> > So why not have it acquire an active superblock reference at the
> > same time?  We don't need struct mount reference there - all it
> > takes in increment of inode->i_sb->s_active on try_break_deleg()
> > side and deactivate_super() on ->i_sb fetched *before* iput()
> > of ->di_inode on the break_deleg_wait() side...
> > 
> > No need to mess with every user of that thing...

Yeah, I like that a lot better than touching every caller. All the
break_deleg_wait() callers wait in plain process context with the locks
already dropped so deactivate_super() is fine there and the next caller
can't get it wrong.

Please respin it that way. Mind the missing & on s_active in the sketch.

--