Re: [PATCH v4 0/3] Add support for Microchip PAC1711 Power Monitor

From: Jonathan Cameron

Date: Sun Oct 18 2026 - 14:43:42 EST


On Wed, 7 Oct 2026 17:41:52 +0300
Ariana Lazar <ariana.lazar@xxxxxxxxxxxxx> wrote:

> The PAC1711, PAC1721, PAC1811 and PAC1821 products are single-channel power
> monitors with accumulator. The PAC1711 and PAC1721 devices use 12-bit
> resolution for voltage and current measurements and 24 bits for power
> calculations, while PAC1811 and PAC1821 have 16-bit resolution and use 32
> bits for power calculations. The 56-bit accumulator register accumulates
> power (energy) or current (Coulomb counter).
>
> PAC1711 and PAC1811 measure up to 42V Full-Scale Range, respectively 9V for
> PAC1721 and PAC1821.

I think the sashiko comments for this one are a mixed back but the
one about intermediate unsigned state in particular looks like a good spot.
I didn't look closely at all of them.

https://sashiko.dev/#/patchset/20261007-pac1711-v4-0-6ef34d7a7947%40microchip.com

Whilst I do plan to enable sashiko emails for IIO fairly soon (subject
perhaps to more discussions) in the meantime, if you want to speed up
review of your patches, you can reply to the thread addressing what sashiko
has found. That way you save reviewers from trying to figure out what
is true and what is a false positive.

Jonathan