Re: [PATCH] staging: greybus: add blank lines after struct definitions in gbphy.h
From: Okhuomon Ajayi
Date: Sun Oct 18 2026 - 17:50:55 EST
On Fri, Oct 16, 2026 at 5:54 AM Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, Oct 15, 2026 at 10:17:35PM -0400, Julia Lawall wrote:
> >
> >
> > On Thu, 15 Oct 2026, Okhuomon Ajayi wrote:
> >
> > > Add blank lines between the structure definitions and the
> > > to_gbphy_dev() and to_gbphy_driver() macros to improve
> > > readability. This fixes the following checkpatch warning:
> >
> > Thanks for the patch. But I suspect that the lack of a newline was
> > intentional, to show that the #define is closely associated with the
> > previous structure declaration.
>
> That is correct.
>
> thanks,
Thank you i would drop the patch now