Re: [PATCH 2/4] iio: adc: exynos_adc: add Exynos850 support

[Jonathan Cameron]

On Fri, 2 Oct 2026 10:34:46 +0300
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:

> On Thu, Oct 01, 2026 at 04:09:13AM +0100, Alexey Klimov wrote:
> > The Exynos850 ADC controller located inside the CMGP block differs from
> > other Exynos ADC controllers, mainly in its register layout.
> > Specifically, the data register sits at offset 0x08.
> > 
> > Abstract the read_value() operation in driver data exynos_adc_data to
> > support SoC-dependent data register read callbacks.
> > Add the exynos850_adc_data struct that describes Exynos850 ADC ops.
> > It also requires its own hardware initialization and exit routines.
> > Add them as well.  
> 
> Split this to at least two patches:
> - add .read_value() callback and switch existing users
> - add new user
> 
Agreed. Other than that looks fine to me.

Thanks,

Jonathan