Re: [PATCH v7 1/7] x86/hygon: Add Family 0x18 DF node enumeration

[Lin Wang]

Hi Yazen,

On 10/17/2026 10:52 PM, Yazen Ghannam wrote:
> > +EXPORT_SYMBOL_GPL(hygon_pci_dev_to_df_node);
> > +
> These exported functions don't have any callers in this set.
>
> This issue was mentioned in the last revision for a different function.
> But the guidance should be followed in general.

I'll keep the node helpers local and remove their public declarations,
stubs and exports until they have in-tree users.

> > +		return ret;
> > +	}
> > +
> Have you considered cases where the cache build fails but that are
> expected?
>
> We've had similar issues recently like this related to virtualization.
>
> In summary: this failure is a true issue on bare metal, so the user
> should be warned. But the failure is expected within a guest VM.

Agreed. I'll avoid warning when a guest does not expose DF devices,
while keeping the warning for failures on bare metal. The error
returns and cleanup will remain unchanged.

Thanks for the review.

Lin