Re: [PATCH v1 RESEND] vdpa/mlx5: Don't free QP buffers if destroying the QP fails

[Yuho Choi]

On Fri, 16 Oct 2026 at 12:01, Dragos Tatulea <dtatulea@xxxxxxxxxx> wrote:
> This commit message is long and hard to read. Could you make it
> shorter and more readable please?
>
> > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
> > Cc: stable@xxxxxxxxxxxxxxx
> Nothing against the change. But it does not deserve a fixes tag.
>
> > +             /* The QP still owns its buffers */
> >               mlx5_vdpa_warn(&ndev->mvdev, "destroy qp 0x%x\n", vqp->mqp.qpn);
> While here, could you improve the error message please?
> mlx5_vdpa_warn(..., "destroy %s qp 0x%x failed %s\n", vqp->fw ? "fw" : "sw");

Thanks for the review, Dragos. I'll send a v2 with a shorter commit
message, the improved warning, and without the Fixes and stable tags.