Re: [PATCH 2/2] thunderbolt: Don't resume the software CM if the host controller is gone
From: Mika Westerberg
Date: Mon Oct 19 2026 - 00:29:56 EST
Hi,
On Sun, Oct 18, 2026 at 12:39:08PM -0400, Cole Leavitt wrote:
> nhi_resume_noirq() sets nhi->going_away when the host controller is not
> present anymore on resume (commit bdccf295d7cd ("thunderbolt: Do not
> touch the hardware if the NHI is gone on resume")). With going_away set
> tb_ring_start() refuses to start the control channel rings, but the
> software connection manager's tb_resume_noirq() still goes through the
> whole resume sequence. Every control channel request then fails with
> -ESHUTDOWN from __tb_ring_enqueue(), and tb_cfg_read()/tb_cfg_write()
> WARN for each one:
This is not supposed to happen with SW CM systems. I've seen a couple of
times Lenovo BIOS has the PCIe root port hotplug enabled and that's against
what the Barlow Ridge BIOS configuration checklist says. Please check if
there is newer BIOS (Lenovo has been fixing these) and of not report it to
Lenovo.