Re: [PATCH 2/2] iio: adc: ti-ads1299: add driver for TI ADS1299

From: Uwe Kleine-König

Date: Mon Oct 19 2026 - 03:08:26 EST


Hello,

On Sun, Oct 18, 2026 at 09:12:47PM -0300, Stephan Costa Barros wrote:
> +#include <linux/mod_devicetable.h>
> [...]
> +#include <linux/spi/spi.h>

<linux/spi/spi.h> provides both of_device_id and spi_device_id. So there
is no need to also include <linux/mod_devicetable.h>. The latter pulls
in a lot of useless dependencies, so there is actually some harm in
using it.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature