Re: [PATCH v3 2/3] fbcon: Rebuild rotated font buffer on font change

[yyaqia]

On 2026-10-16 09:59, Thomas Zimmermann wrote:
> 
> It's way too long and boring to read. Can you please try to shorten the
> AI-generated commit description?
> 
> 

Sorry for that, I was a bit lazy to think commit desc by myself. I am
new to kernel and a little afraid that my message does not cover all
things.

> > - Also select the blitting type again in the error path of
> >    fbcon_do_set_font(). On tile-blitting hardware, set_blitting_type()
> >    uploads the font map to the text engine; without the second call, a
> >    failed vc_resize() left the engine with the rejected font (found by
> >    the Sashiko review).
> 
> The problem is that rotate_font can fail as well. Handling that in the error
> path is not possible; hence results might be worse than keeping the rejected
> font.  Can you try to keep the original rotated font and reinstall that
> directly?
> 

Good advice, I will fix this in V4.

Thanks for your review,
Yao Yiqi