RE: [PATCH v3 5/6] iio: imu: adis16607: Add external clock sync support

[Sabau, Radu bogdan]

> -----Original Message-----
> From: Jonathan Cameron <jic23@xxxxxxxxxx>
> Sent: Saturday, October 17, 2026 5:03 AM

...

> > Add support for an optional external clock (clocks property),
> > selecting between SYNC_DIRECT and SYNC_SCALED modes depending on the
> > supplied frequency, with the internal 8 kHz clock used as the default
> > when no clock is provided.
> >
> > Signed-off-by: Radu Sabau <radu.sabau@xxxxxxxxxx>
> 
> Just a very quick look as I'm out of time for today.
> 
> > +
> > +	/* Default dec=0 after reset: period = 1 / clk_freq */
> 
> Why does the comment make sense now but didn't before?

Yep, this is a double standard... For USER_SYNC I chose to
write the full state explicitly regardless of its reset default,
specifically so the code doesn't depend on that default holding..
Dropping the comment and the assumption: I'll read DEC_RATE
here instead, same as adis16607_get_freq() already does, so it's
consistent either way rather than picking and choosing.