Re: [PATCH v4] staging: iio: adt7316: use kstrtobool() for sysfs boolean parsing

From: Andy Shevchenko

Date: Mon Oct 19 2026 - 05:41:42 EST


On Mon, Oct 19, 2026 at 04:09:19AM +0100, Jonathan Cameron wrote:
> On Sun, 18 Oct 2026 17:31:08 +0300
> Abdelnasser Hussein <abdelnasserhussein11@xxxxxxxxx> wrote:
>
> > Replace manual character checks (e.g., buf[0] == '1') with the standard
> > kstrtobool() API in sysfs store functions.
> >
> > Signed-off-by: Abdelnasser Hussein <abdelnasserhussein11@xxxxxxxxx>
> Ah. No need to resend just to drop a tag. I did that on v3.

...

> > #include <linux/i2c.h>
> > #include <linux/rtc.h>
> > #include <linux/module.h>
> > +#include <linux/kstrtox.h>

May you also move this before rtc.h to keep it a bit more ordered than now?

> > #include <linux/iio/iio.h>
> > #include <linux/iio/events.h>

--
With Best Regards,
Andy Shevchenko