Re: [PATCH 06/10] ARM: dts: omap: dm816x: Update USB node
From: Andrew Goodbody
Date: Mon Oct 19 2026 - 05:42:23 EST
On 17/10/2026 07:39, Andreas Kemnade wrote:
On Fri, 16 Oct 2026 16:41:21 +0200
Ettore Chimenti <ettore.chimenti@xxxxxxxxxx> wrote:
From: Andrew Goodbody <andrew.goodbody@xxxxxxxxxx>
USB node was not working correctly with DMA enabled as the supporting
code had been updated without updating this SoC's device tree. Bring the
device tree more up to date so that it works with DMA enabled.
Signed-off-by: Andrew Goodbody <andrew.goodbody@xxxxxxxxxx>
Signed-off-by: Ettore Chimenti <ettore.chimenti@xxxxxxxxxx>
---
arch/arm/boot/dts/ti/omap/dm816x.dtsi | 41 +++++++++++++++++++++--------------
1 file changed, 25 insertions(+), 16 deletions(-)
diff --git a/arch/arm/boot/dts/ti/omap/dm816x.dtsi b/arch/arm/boot/dts/ti/omap/dm816x.dtsi
index 7f3ef3a00ab8..5be9efc60785 100644
--- a/arch/arm/boot/dts/ti/omap/dm816x.dtsi
+++ b/arch/arm/boot/dts/ti/omap/dm816x.dtsi
@@ -574,18 +574,27 @@ uart3: serial@48024000 {
};
/* NOTE: USB needs a transceiver driver for phys to work */
- usb: usb_otg_hs@47401000 {
- compatible = "ti,am33xx-usb";
- reg = <0x47401000 0x400000>;
- ranges;
+ usb: target-module@47400000 {
+ compatible = "ti,sysc-omap4", "ti,sysc";
+ ti,hwmods = "usb_otg_hs";
Why do we still need this? It is depcrecated.
Regards,
Andreas
Without that line we get the following on boot and USB does not work
[ 0.110148] omap_hwmod: usb_otg_hs: no dt node
[ 0.110163] ------------[ cut here ]------------
[ 0.110169] WARNING: arch/arm/mach-omap2/omap_hwmod.c:2332 at _init+0x1a4/0x4c4, CPU#0: swapper/0/1
[ 0.110198] omap_hwmod: usb_otg_hs: doesn't have mpu register target base
[ 0.110204] Modules linked in:
[ 0.110221] CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 7.3.0-rc7-g8e3242ad06d4 #11 VOLUNTARY
[ 0.110235] Hardware name: Generic ti816x (Flattened Device Tree)
[ 0.110242] Call trace:
[ 0.110254] unwind_backtrace from show_stack+0x10/0x14
[ 0.110284] show_stack from dump_stack_lvl+0x54/0x68
[ 0.110307] dump_stack_lvl from __warn+0x8c/0x194
[ 0.110331] __warn from warn_slowpath_fmt+0x1a8/0x1b8
[ 0.110350] warn_slowpath_fmt from _init+0x1a4/0x4c4
[ 0.110367] _init from omap_hwmod_for_each+0x30/0x5c
[ 0.110393] omap_hwmod_for_each from __omap_hwmod_setup_all+0x34/0xf8
[ 0.110412] __omap_hwmod_setup_all from do_one_initcall+0x54/0x2a4
[ 0.110431] do_one_initcall from kernel_init_freeable+0x208/0x2bc
[ 0.110453] kernel_init_freeable from kernel_init+0x18/0x134
[ 0.110471] kernel_init from ret_from_fork+0x14/0x28
[ 0.110484] Exception stack(0xdf009fb0 to 0xdf009ff8)
[ 0.110496] 9fa0: 00000000 00000000 00000000 00000000
[ 0.110507] 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[ 0.110516] 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000
[ 0.110611] ---[ end trace 0000000000000000 ]---
Andrew