Re: [PATCH v2 4/9] irqchip/irq-qcom-mpm: Prepare common access path for timer and pin regs
From: Konrad Dybcio
Date: Mon Oct 19 2026 - 07:24:17 EST
On 10/15/26 11:55 AM, Sneh Mankad wrote:
> The vMPM layout starts with two timer registers followed by pin register
> banks (ENABLE/FALLING/RISING/POLARITY/STATUS), each with reg_stride
> number of entries.
>
> Use qcom_mpm_offset() as the common addressing helper for both timer and
> pin register accesses based on that layout.
>
> vMPM has MPM_REG_* values represented as contiguous register IDs,
> hence replace the macros with enum qcom_mpm_reg and modify the accessor
> helpers accordingly.
>
> Signed-off-by: Sneh Mankad <sneh.mankad@xxxxxxxxxxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
Konrad