RE: [PATCH v5 3/8] dt-bindings: mfd: realtek,rtd1xxx: Add interrupt controller child node

[Yu-Chun Lin [林祐君]]

Hi Krzysztof,

> On Mon, Oct 19, 2026 at 12:06:48AM +0800, Yu-Chun Lin wrote:
> > Allow an interrupt controller as a child node by referencing the
> > rtd1319-intc-iso schema, update additionalProperties to
> > unevaluatedProperties, and append a usage example.
> 
> I do not see that "update".
> 

Sorry about this. I updated the diff but missed updating the commit
message. Will fix.

> >
> > Signed-off-by: Yu-Chun Lin <eleanor.lin@xxxxxxxxxxx>
> > ---
> >  .../bindings/mfd/realtek,rtd1xxx.yaml         | 28
> +++++++++++++++++++
> >  1 file changed, 28 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/mfd/realtek,rtd1xxx.yaml
> > b/Documentation/devicetree/bindings/mfd/realtek,rtd1xxx.yaml
> > index 717e29c37b36..b21e14df2879 100644
> > --- a/Documentation/devicetree/bindings/mfd/realtek,rtd1xxx.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/realtek,rtd1xxx.yaml
> > @@ -65,6 +65,10 @@ properties:
> >      const: 1
> >
> >  patternProperties:
> > +  "^interrupt-controller":
> > +    $ref: /schemas/interrupt-controller/realtek,rtd1319-intc-iso.yaml
> > +    unevaluatedProperties: false
> > +
> >    '@[0-9a-f]+$':
> >      type: object
> 
> What is this for then? Should it be removed?
> 

The original syscon compatible has other child nodes that do have 'reg'
properties and unit addresses, so this pattern is still needed for them.

> >
> > @@ -76,3 +80,27 @@ required:
> >    - reg
> >
> >  additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +
> > +    syscon@7000 {
> > +        compatible = "realtek,rtd1625-iso", "syscon", "simple-mfd";
> > +        reg = <0x7000 0x1000>;
> > +        ranges = <0x0 0x7000 0x1000>;
> > +        #address-cells = <1>;
> > +        #size-cells = <1>;
> 
> Why do you have cells it your child has no addressing?
>
> > +
> > +        interrupt-controller {
> 
> So the binding requires children with unit address, yes?
> 

The interrupt-controller does not need a unit address because it accesses
the registers via the parent's regmap.

Will update the example to remove the unnecessary properties from the
parent as follows:

syscon@7000 {
    compatible = "realtek,rtd1625-iso", "syscon", "simple-mfd";
    reg = <0x7000 0x1000>;

    interrupt-controller {
        compatible = "realtek,rtd1625-intc-iso";
        interrupt-controller;
        interrupt-parent = <&gic>;
        interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>,
            <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>,
            <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
        #address-cells = <0>;
        #interrupt-cells = <1>;
    };
};

Best regards,
Yu-Chun

> Best regards,
> Krzysztof