Re: [PATCH v2 4/6] arm64: dts: qcom: glymur-crd: Add PM8010 camera PMIC

[Konrad Dybcio]

On 10/15/26 12:52 PM, Nihal Kumar Gupta wrote:
> From: Jishnu Prakash <jishnu.prakash@xxxxxxxxxxxxxxxx>
> 
> Add the PM8010 PMIC node with seven LDO regulators and pinctrl
> configuration for reset pin. The LDOs are needed to power the
> camera sensors and associated hardware.

[...]

> +	pm8010: pmic@8 {
> +		compatible = "qcom,pm8010-i2c";
> +		reg = <0x8>;
> +
> +		reset-gpios = <&tlmm 106 GPIO_ACTIVE_LOW>;
> +
> +		vdd-l1-l2-supply = <&vreg_l6p>;
> +		vdd-l3-l4-supply = <&vreg_bob1_e0>;
> +		vdd-l5-supply = <&vreg_bob1_e0>;
> +		vdd-l6-supply = <&vreg_bob1_e0>;
> +		vdd-l7-supply = <&vreg_bob1_e0>;
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pm8010_default>;

property-n
property-names

in this order, please

[...]

> +		regulators {
> +			vreg_l1p: ldo1 {
> +				regulator-name = "vreg_l1p";
> +				regulator-min-microvolt = <1200000>;
> +				regulator-max-microvolt = <1200000>;
> +			};

Shouldn't this be 1.104 V?


[...]
 > +	pm8010_default: pm8010-default-state {
> +		reset-n-pins {

Drop this inner node and put the properties directly under pm8010_default

Konrad

> +			pins = "gpio106";
> +			function = "gpio";
> +			drive-strength = <2>;
> +			bias-disable;
> +		};
> +	};
> +
>  	sdc2_card_det_n: sd-card-det-n-state {
>  		pins = "gpio221";
>  		function = "gpio";
>