RE: [PATCH v3 1/4] ASoC: dt-bindings: Add Cadence I2S-SC controller

[Joakim Zhang (张强庆)]

> -----Original Message-----
> From: Rob Herring <robh@xxxxxxxxxx>
> Sent: Friday, October 9, 2026 10:19 PM
> To: Joakim Zhang (张强庆) <joakim.zhang@xxxxxxxxxxx>
> Cc: lgirdwood@xxxxxxxxx; broonie@xxxxxxxxxx; krzk+dt@xxxxxxxxxx;
> conor+dt@xxxxxxxxxx; perex@xxxxxxxx; tiwai@xxxxxxxx; p.zabel@xxxxxxxxxxxxxx;
> cix-kernel-upstream <cix-kernel-upstream@xxxxxxxxxxx>; linux-
> sound@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 1/4] ASoC: dt-bindings: Add Cadence I2S-SC controller
> 
> EXTERNAL EMAIL
> 
> On Fri, Oct 09, 2026 at 05:25:49PM +0800, joakim.zhang@xxxxxxxxxxx wrote:
> > From: Joakim Zhang <joakim.zhang@xxxxxxxxxxx>
> >
> > Add the DT binding for the Cadence I2S-SC controller integrated in the
> > CIX SKY1 audio subsystem. I2S-SC is a full-duplex stereo controller
> > supporting standard I2S, left/right-justified and DSP formats, plus
> > TDM operation with up to 16 slots.
> >
> > Signed-off-by: Joakim Zhang <joakim.zhang@xxxxxxxxxxx>
> > ---
> >  .../bindings/sound/cix,sky1-i2s-sc.yaml       | 93 +++++++++++++++++++
> >  1 file changed, 93 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/sound/cix,sky1-i2s-sc.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/sound/cix,sky1-i2s-sc.yaml
> > b/Documentation/devicetree/bindings/sound/cix,sky1-i2s-sc.yaml
> > new file mode 100644
> > index 000000000000..3fdf2334c492
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/cix,sky1-i2s-sc.yaml
> > @@ -0,0 +1,93 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/cix,sky1-i2s-sc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Cadence I2S-SC controller
> > +
> > +maintainers:
> > +  - Joakim Zhang <joakim.zhang@xxxxxxxxxxx>
> > +
> > +description: |
> > +  The Cadence I2S-SC controller integrated in the CIX SKY1 audio subsystem.
> > +  It supports full-duplex stereo playback and capture in standard
> > +I2S,
> > +  left/right-justified and DSP modes, as well as TDM operation with
> > +up to
> > +  16 slots. The transmitter and receiver are started and stopped
> > +together
> > +  by the controller.
> > +
> > +allOf:
> > +  - $ref: dai-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: cix,sky1-i2s-sc
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 4
> > +
> > +  clock-names:
> > +    items:
> > +      - const: hst
> > +      - const: i2s
> > +      - const: audio-clk0
> > +      - const: audio-clk2
> > +
> > +  resets:
> > +    maxItems: 1
> > +
> > +  dmas:
> > +    minItems: 1
> > +    maxItems: 2
> > +    description:
> > +      One DMA channel for instances wired for a single direction, either
> > +      "tx" or "rx", or two channels for both transmit and receive.
> > +
> > +  dma-names:
> > +    minItems: 1
> > +    maxItems: 2
> > +    items:
> > +      enum: [ tx, rx ]
> > +
> > +  "#sound-dai-cells":
> > +    const: 0
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - clocks
> > +  - clock-names
> > +  - resets
> > +  - dmas
> > +  - dma-names
> > +  - "#sound-dai-cells"
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +    audss_dmac: dma-controller {
> > +        #dma-cells = <1>;
> > +    };
> 
> Drop. We don't put providers in examples. What example made you think you
> needed it? And if you do, why not the clock, reset, and interrupt providers?

Yes, will drop, thanks.

Joakim