Re: [PATCH] ASoC: cs42l56: Remove the ADC Mute Switch control

[Charles Keepax]

On Mon, Oct 19, 2026 at 09:40:22PM +0900, HyeongJun An wrote:
> The ADC Mute Switch control writes bits 2 and 3 of the Misc ADC Control
> register. These are the ADCA Invert and ADCB Invert bits, which have
> their own controls. The ADC mute bits are bits 0 and 1, and the DAI mute
> callback already sets them.
> 
> So the control has never muted the ADCs, and nobody can be relying on
> it. Remove it rather than point it at the mute bits, so the ADCs are
> muted in one place only.
> 
> Fixes: 272b5edd3b8f ("ASoC: Add support for CS42L56 CODEC")
> Suggested-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
> Link: https://lore.kernel.org/all/atXh3Br+fuH83S0q@xxxxxxxxxxxxxxxxxxxxx/
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: HyeongJun An <sammiee5311@xxxxxxxxx>
> ---

Reviewed-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>

Thanks,
Charles