Re: [PATCH net-next 0/4] net: pse-pd: core fixes ahead of the controller notifier

From: Kory Maincent

Date: Mon Oct 19 2026 - 08:56:26 EST




On 10/18/26 10:18, Carlo Szelinsky wrote:
These four PSE core fixes were part of the "decouple controller lookup
from MDIO probe" series [1]; Oleksij asked to split them out. They do
not need phylib, and each one fixes a problem on its own:

1. Unregister frees the PI data while the controller can still be
found. Take it off the list and stop the IRQ and the worker first.
2. A failed registration leaks memory, and can leave freed power
domains in the global map. Clean up on the error paths.
3. si3474: use dev_err_probe(), so the deferral from 4 is not logged
as an error.
4. Defer the PSE driver's probe until every PI's vpwr supply is there.

Patch 1 conflicts with the pending net series [2]; keep the order from
patch 1. Patch 2 conflicts with two of the net fixes posted alongside
[3]; the note below its --- explains how to merge them.

Tested in QEMU on arm64 with KASAN, lockdep and kmemleak: controllers
whose supply never appears defer, and an injected pse_register_pw_ds()
failure is cleaned up and retried. The only KASAN reports are the known
stale-handle bug at MDIO bus unbind, the same without this series; the
decouple series fixes it. This series, the decouple series and the net
fixes together also run on a Hasivo S600WP (hs104), with 200 controller
unbind/bind cycles and no warnings or leaks. Every patch builds with
W=1, and PHYLIB=m, PHYLIB=n and PSE_CONTROLLER=n link.

These are fixes, please send them to net instead.

--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com