Re: [PATCH v3 2/2] arm64: dts: qcom: Add support for Xiaomi 17 Ultra phones

[Igor Belwon]

Hi Abel!

Thanks for your review.

On Mon Oct 19, 2026 at 12:57 PM CEST, Abel Vesa wrote:
> On 26-10-18 11:17:57, Igor Belwon wrote:
>> The Xiaomi 17 Ultra device, codenamed 'nezha', is a flagship mobile
>> phone released by Xiaomi in 2025 (China)/2026 (EEA). It uses the
>> Qualcomm Kaanapali SoC.
>> 
>> This device's configuration is based on the 'MTP' from Qualcomm,
>> as is also referenced in the downstream sources. Apart from the
>> usual differences (i.e. codecs, panel), it also uses the newer
>> WCN7860 (peach) connectivity chip, which is why WiFi/BT are not
>> brought up.
>> 
>> The difference between the EEA and the Chinese model is the battery
>> capacity, notably, the EEA model has a smaller 6000 mAh battery when
>> compared to the CN 6800 mAh SiC battery.
>> 
>> Currently implemented features are:
>>  - Booting
>>  - Power and volume keys
>>  - Storage (UFS)
>>  - USB-C Peripheral and Host modes
>>  - GPU
>>  - Fuel gauge
>>  - ADSP, CDSP, SoCCP remote processors
>> 
>> Signed-off-by: Igor Belwon <igor.belwon@xxxxxxxxxxxxxxxxxxxxxxxxxx>

[snip]

>> +		sleep_clk: sleep-clk {
>> +			compatible = "fixed-clock";
>> +			clock-frequency = <32000>;
>
> Is this not 32764 ?
>

Downstream specifies 32000:
- https://github.com/MiCode/kernel_devicetree/blob/popsicle-w-oss/qcom/canoe.dtsi#L1439

>> +			#clock-cells = <0>;
>> +		};

Ack for the rest.

Warm regards,
Igor