[PATCH v5 07/16] media: sony-starvis2: Correct the exposure range
From: Dave Stevenson
Date: Mon Oct 19 2026 - 11:40:15 EST
The software reference for imx678 lists register SHR0 setting
the shutter sweep time with a valid range of 4 to (Number of
lines per frame - 1), and then gives the example of all-pixel
scan mode with VMAX=2250 and SHR0=2249 giving an integration
time of "1H + Toffset" (further defining Toffset as 0).
The driver defining STARVIS2_EXPOSURE_MIN as 2 would therefore
be contradictory, and doubles the minimum exposure achievable.
The maximum exposure is derived from STARVIS2_SHR_MIN which
is defined as 8, when the actual minimum for that register is
4.
Correct STARVIS2_EXPOSURE_MIN and STARVIS2_SHR_MIN.
Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
---
drivers/media/i2c/sony-starvis2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/sony-starvis2.c b/drivers/media/i2c/sony-starvis2.c
index 56fa2d5ea3fe..1c3dcae5e0a4 100644
--- a/drivers/media/i2c/sony-starvis2.c
+++ b/drivers/media/i2c/sony-starvis2.c
@@ -61,10 +61,10 @@
/* SHR internal */
#define STARVIS2_REG_SHR CCI_REG24_LE(0x3050)
-#define STARVIS2_SHR_MIN 8
+#define STARVIS2_SHR_MIN 4
/* Exposure control */
-#define STARVIS2_EXPOSURE_MIN 2
+#define STARVIS2_EXPOSURE_MIN 1
#define STARVIS2_EXPOSURE_STEP 1
#define STARVIS2_EXPOSURE_DEFAULT 1000
--
2.34.1