Re: [PATCH] [v3] serial: 8250: remove obsolete and broken PORT_RSA support

[Jiri Slaby]

On 19. 10. 26, 10:56, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> For all I can tell, the RSA support in the 8250 driver is not functional
> and has not been for a long time.
>
> The RSA-DV II/S ISA card[1] was sold by IODATA in the 1990s as a faster
> alternative to regular ISA serial ports, and it was discontinued in
> 2002. Linux support was added by Kiyokazu SUTO in 2000.
>
> The driver defines an I/O port base address of -8 (negative eight),
> which should always get refused by request_region on all architectures
> for being outside of the valid resource range.
>
> Further, it seems that a patch to setserial would be required in order
> to set PORT_RSA when not using autoconfiguration.
>
> This patch removes all code related to the RSA support, with the exception
> of the user-visible PORT_RSA definition.
>
> Link: http://translate.google.com/translate?hl=en&sl=ja&u=http://www.iodata.jp/products/network/rsadv2s.htm
> Link: https://lore.kernel.org/all/1309211120-2803-6-git-send-email-arnd@xxxxxxxx/
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Acked-by: Jiri Slaby <jirislaby@xxxxxxxxxx>


--
js
suse labs