Re: [PATCH v4 5/6] watchdog: w83627hf_wdt: Store Super I/O configurations in platform data

[Tzung-Bi Shih]

On Tue, Oct 13, 2026 at 03:58:49PM +0200, Paul Louvel wrote:
> Instead of using global variables, store Super I/O related
> configurations in platform data.
>
> Signed-off-by: Paul Louvel <paul.louvel@xxxxxxxxxxx>

With a few nits,

Reviewed-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>

>  /*
>   * On some systems, the NCT6791D comes with a companion chip and the
>   * watchdog function is in this companion chip. We must use a different
>   * unlocking sequence to access the companion chip.
>   */
> -static int __init wdt_use_alt_key(const struct dmi_system_id *d)
> -{
> -	wdt_cfg_enter = 0x88;
> -	wdt_cfg_leave = 0xBB;
>  

Please remove the blank line as well.

> -	return 0;
> -}
> +static const struct w83627hf_sio_pdata w83627hf_sio_pdata_alt = {
> +	.cfg_enter = 0x88,
> +	.cfg_leave = 0xBB
> +};
>  
>  static const struct dmi_system_id wdt_dmi_table[] __initconst = {
>  	{
> @@ -554,7 +564,7 @@ static const struct dmi_system_id wdt_dmi_table[] __initconst = {
>  			DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "INVES"),
>  			DMI_EXACT_MATCH(DMI_BOARD_NAME, "SHARKBAY"),
>  		},
> -		.callback = wdt_use_alt_key,
> +		.driver_data = (void *) &w83627hf_sio_pdata_alt
                                       ^
Please remove the extra space.