Re: [PATCH 06/10] ARM: dts: omap: dm816x: Update USB node
From: Andrew Goodbody
Date: Mon Oct 19 2026 - 13:55:23 EST
On 19/10/2026 14:45, Andreas Kemnade wrote:
On Mon, 19 Oct 2026 10:36:37 +0100
Andrew Goodbody <andrew.goodbody@xxxxxxxxxx> wrote:
On 17/10/2026 07:39, Andreas Kemnade wrote:
On Fri, 16 Oct 2026 16:41:21 +0200
Ettore Chimenti <ettore.chimenti@xxxxxxxxxx> wrote:
From: Andrew Goodbody <andrew.goodbody@xxxxxxxxxx>
USB node was not working correctly with DMA enabled as the supporting
code had been updated without updating this SoC's device tree. Bring the
device tree more up to date so that it works with DMA enabled.
Signed-off-by: Andrew Goodbody <andrew.goodbody@xxxxxxxxxx>
Signed-off-by: Ettore Chimenti <ettore.chimenti@xxxxxxxxxx>
---
arch/arm/boot/dts/ti/omap/dm816x.dtsi | 41 +++++++++++++++++++++--------------
1 file changed, 25 insertions(+), 16 deletions(-)
diff --git a/arch/arm/boot/dts/ti/omap/dm816x.dtsi b/arch/arm/boot/dts/ti/omap/dm816x.dtsi
index 7f3ef3a00ab8..5be9efc60785 100644
--- a/arch/arm/boot/dts/ti/omap/dm816x.dtsi
+++ b/arch/arm/boot/dts/ti/omap/dm816x.dtsi
@@ -574,18 +574,27 @@ uart3: serial@48024000 {
};
/* NOTE: USB needs a transceiver driver for phys to work */
- usb: usb_otg_hs@47401000 {
- compatible = "ti,am33xx-usb";
- reg = <0x47401000 0x400000>;
- ranges;
+ usb: target-module@47400000 {
+ compatible = "ti,sysc-omap4", "ti,sysc";
+ ti,hwmods = "usb_otg_hs";
Why do we still need this? It is depcrecated.
Regards,
Andreas
Without that line we get the following on boot and USB does not work
[ 0.110148] omap_hwmod: usb_otg_hs: no dt node
It is somewhat odd to use both ti-sysc and hwmod. It looks like a
half conversion.
For an example how usb_otg_hs was converted to ti-sysc for omap3, look at
42a79edd4a3dc1bb8e89fd2849f9e8e1e1c13977...v6.1-rc1
It has no hwmod stuff left.
Regards,
Andreas
Thank you. That was the pointer I needed to sort this out.
Andrew