Re: [PATCH 1/6] ACPI: extlog: fix extlog_mem_event build issue

[Pierre Gondois]

On 10/19/26 18:36, Jonathan Cameron wrote:
> On Mon, 19 Oct 2026 16:56:08 +0200
> Pierre Gondois <pierre.gondois@xxxxxxx> wrote:
>
> > With CONFIG_ACPI_EXTLOG=n and with the following command:
> > make -j4 drivers/acpi/acpi_extlog.o drivers/acpi/
> >
> > trace_extlog_mem_event() is not defined. Add a extlog_mem_err_event()
> > wrapper to fix the build issue.
> >
> > Signed-off-by: Pierre Gondois <pierre.gondois@xxxxxxx>
> I'm lost.  This file is normally only built if
> CONFIG_ACPI_EXTLOG is not = "n" so how do you get to this code.
> Ah you are forcing build of a file...
>
> If you do need to do this sort of ifdefery it belongs in a header with
> the function cleanly stubbed rather than in here.
>
> Anyhow, far as I can tell this doesn't make any sense for
> upstream.
>
> J
Ok sure this will be dropped.