Re: [PATCH 6.6 0000/1674] 6.6.160-rc1 review

[Peter Schneider]

Am 19.10.2026 um 18:54 schrieb Sasha Levin:
> On Mon, Oct 19, 2026 at 06:02:37AM +0200, Peter Schneider wrote:
> > # first bad commit: [7c1e132b0967210526de05e7af6f1c26ad0c1516] sysfs: Introduce a mechanism to hide static attribute_groups
>
> Thanks for bisecting this.
>
> > I think the problem is, that if you take this patch for stable, you need to also take the patch which is upstream [
> > cd69fedf58f8ab1ab511f7c6ac1969cebf1c935f] sysfs: Fix crash on empty group attributes array. It addresses the exact crash
> > that I've run into.
>
> Rather than adding cd69fedf58f8, I dropped d87c295f599c ("sysfs: Introduce a
> mechanism to hide static attribute_groups") and its dependent c7fbb8218b4a
> ("sysfs: check visibility before changing group attribute ownership") from the
> 6.6 and 6.1 queues.

Yeah, that seems to be the cleaner approach. I just tested this, and this works fine, too.

Will there be an -rc2?

Beste Grüße,
Peter Schneider

--
Climb the mountain not to plant your flag, but to embrace the challenge,
enjoy the air and behold the view. Climb it so you can see the world,
not so the world can see you.                    -- David McCullough Jr.

OpenPGP:  0xA3828BD796CCE11A8CADE8866E3A92C92C3FF244
Download: https://www.peters-netzplatz.de/download/pschneider1968_pub.asc
https://keys.mailvelope.com/pks/lookup?op=get&search=pschneider1968@xxxxxxxxxxxxxx
https://keys.mailvelope.com/pks/lookup?op=get&search=pschneider1968@xxxxxxxxx