Re: [PATCH ath-next v4 1/8] wifi: ath9k: return an error from a failed multi-register read

[Toke Høiland-Jørgensen]

Nerijus Bendžiūnas <nerijus.bendziunas@xxxxxxxxx> writes:

> ath9k_multi_regread() logs a failed or timed-out WMI read and still
> copies its result buffer to the caller, so the caller gets
> uninitialised stack data for every register it asked for. The MIB
> counters in ath9k_hw_update_mibstats() then take arbitrary jumps, and
> an EEPROM read at probe fails on the checksum rather than on the read.
>
> Give the multi_read op a return value, return the WMI error from
> ath9k_multi_regread(), and check it: skip the counter update and fail
> the EEPROM fill when the read did not happen.
>
> Fixes: 09a525d33870 ("ath9k_htc: Add multiple register read API")
> Assisted-by: LLM
> Signed-off-by: Nerijus Bendžiūnas <nerijus.bendziunas@xxxxxxxxx>

Acked-by: Toke Høiland-Jørgensen <toke@xxxxxxx>