Re: [PATCH net-next 1/4] net: pse-pd: unlink the controller before freeing its PI data

[Carlo Szelinsky]

On Mon, 19 Oct 2026 08:35:36 +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> [Severity: Low]
> Should this have a Fixes: tag?

Yes. The patch moves to net, where it gets Fixes tags.

> [Severity: Medium]
> This isn't a bug introduced by this patch, but is the IRQ passed to
> disable_irq() here always one the controller owns?

No. That is an older bug, fixed in net by "net: pse-pd: do not keep a
failed IRQ in pcdev->irq".

> [Severity: High]
> Unlinking from pse_controller_list blocks new of_pse_control_get()
> lookups. What about the pse_control handles that consumers already hold?

Right, that is an older bug, and this commit message claims too much.
The PSE notifier series fixes it: there, the PHYs drop their handles
before the PI data is freed. In net, this patch is replaced by two
patches of [1]; the cover letter of [1] says that this case is not
fixed there.

> [Severity: High]
> Can ntf_work be queued again after this cancel_work_sync()?

Yes, through a handle that a consumer still holds, so this is the same
older bug as above. The notifier series cancels the work only after
all handles are dropped.

> [Severity: High]
> Can the PI regulators still use pcdev->pi after pse_release_pis() frees
> it here?

Yes, an older bug. It is fixed by the second patch of [1], which I
will rework and fold into the net series.

[1] https://lore.kernel.org/netdev/20260813200653.980170-1-github@xxxxxxxxxxxx/

Carlo