Re: [PATCH net 05/10] net: pse-pd: check the PI state under the lock when setting a power limit

[Carlo Szelinsky]

On Mon, 19 Oct 2026 08:51:13 +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> [Severity: Medium]
> The scenario in the commit message, where budget is reserved for a port
> that is no longer powered, looks closed now. But can the budget and the
> hardware limit still drift apart in the other direction?

Yes, but that was already possible before this patch, which does not
make it worse. A real fix needs the budget update and the hardware
limit write under one lock, and that needs a different structure. As
Kory wrote, PSE PIs may stop being regulator providers, which changes
this code, so I leave it for now.

> [Severity: Low]
> This isn't a bug, but the kernel-doc for pse_pi_update_pw_budget() still
> says:

Right. The next version says that 0 can also mean that nothing
changed, and that callers check *updated before they roll back.

Carlo