Re: [PATCH ath-next 1/3] wifi: ath10k: set the PMF peer flag on WCN3990

[Aleksei Kharlamov]

Hello,

On 10/16/26 02:17, Shunsuke Nagashima via B4 Relay wrote:
> ath10k sets the PMF flag in the peer assoc command only when the
> firmware file advertises ATH10K_FW_FEATURE_MFP_SUPPORT. That check came
> with commit 90eceb3b5fb0 ("ath10k: set peer MFP flag in peer assoc
> command"), because at that time "only firmwares 10.1.561 and above have
> support for MFP". The WCN3990 firmware-5.bin files in linux-firmware do
> not set that feature bit, so the flag is never sent on WCN3990, although
> mac80211 negotiates PMF with the AP. ath11k and ath12k set the flag for
> every MFP station.

I independently found the same issue while investigating connectivity 
issues on fairphone 4 (WCN3988, qcom,wcn3990-wifi, slightly patched 
kernel v7.2.0-sm6350, firmware WLAN.HL.3.3.1-01704-QCAHLSWMTPLZ-1).

Setting PMF peer flag (my patch is crude and very similar to yours) 
significantly improves the connection performance (please keep in mind 
that fp4 seems to currently have multiple other issues, such as missing 
a correct "board" file). I only tested station mode.

Thanks,
Aleksei