Re: [PATCH net v3 0/5] eth: fbnic: harden Rx and Tx completion handling

[Jakub Kicinski]

On Mon, 12 Oct 2026 13:15:55 +0900 Yehyeong Lee wrote:
> The Rx and Tx completion descriptors carry buffer ids, offsets and
> lengths that the device writes and the driver consumes without
> validating. v2 bounded the Rx buffer index against the array only, which
> the review found insufficient: an in-range id naming an unposted slot
> still reaches a NULL page, a bare META completion still builds an skb from
> a NULL buffer, and the offset, length and the Tx completion head are not
> checked at all.

AFAIU we are not required to add silly safety checks to fast path of
PCIe and SoC drivers. They can be assumed non-malicious. 

Please don't waste our time.
-- 
pw-bot: reject