Re: [PATCH 2/2] spi: ti-qspi: handle setup clock runtime resume failure

From: Atsushi Nemoto

Date: Mon Oct 19 2026 - 19:57:39 EST


On 2026/10/19 17:44, Jiale Yao wrote:
> ti_qspi_setup_clk() writes controller registers after an unchecked
> pm_runtime_resume_and_get() call. Runtime resume can fail, leaving the
> controller unavailable while the helper continues with the register
> access and later drops a reference that was not acquired.
>
> Return the runtime resume error from the helper and propagate it through
> the memory-map and transfer paths before any clock register access.
>
> Fixes: 8d0b512844fd ("spi: spi-ti-qspi: Support per-transfer and per-slave speed_hz settings")
> Signed-off-by: Jiale Yao <yaojiale02@xxxxxxx>
> ---
> drivers/spi/spi-ti-qspi.c | 21 ++++++++++++++++-----
> 1 file changed, 16 insertions(+), 5 deletions(-)

Thank you for fixing it.

Reviewed-by: Atsushi Nemoto <atsushi.nemoto@xxxxxxxxxx>