Re: [PATCH net-next v19 01/13] phylink: Add phylink_mac_interrupt

[Jakub Kicinski]

On Sun, 11 Oct 2026 07:32:52 +0200 Birger Koblitz wrote:
> > The function comment notes that SFP modules do not support interrupts. However,
> > when an SFP module is physically unplugged, the electrical link drops. Could
> > this link drop trigger the MAC interrupt being handled here?  
> 
> The way this code-review is done by whoever handles the AI is absolutely 
> not OK. The same patch was considered to be free of errors in the 
> previous round. Now something is brought up that has been discussed ad 
> nauseam before, including an analysis by Andrew, and found correct.
> The minimum I expect is that emails relating to the patches are being 
> looked at and also understood!

You are responding to the main Sashiko instance, not the netdev one.
Due to infinite wisdom of some MM people these are not even CCed 
to netdev (I guess CCing the USB list triggers them?)
You can ignore the feedback form that instance for networking patches.

Unfortunately our instance didn't run because patch 4 breaks the build
(patch 12 fixes it). Our instance tries to save tokens and doesn't run
on patches where basic CI checks fail.

drivers/net/usb/ax88179_178a.c:691:8: error: use of undeclared label 'err_nodev'
  691 |                 goto err_nodev;
      |                      ^
-- 
pw-bot: cr