RE: [PATCH net-next v9 11/11] net: phy: ncn26000: Support for loopback

[Selvamani Rajagopal]

> -----Original Message-----
> From: netdev-bot+sashiko@xxxxxxxxxx <netdev-bot+sashiko@xxxxxxxxxx>
> Sent: Saturday, October 10, 2026 12:40 PM
> Subject: Re: [PATCH net-next v9 11/11] net: phy: ncn26000: Support for loopback
> 
> 
> 
> Critical: 0 · High: 0 · Medium: 1 · Low: 1
> 
> 
> - [Medium] This patch adds loopback support for the S2500 by pointing
> .set_loopback at genphy_loopback_no_speed().
> - [Low] The kernel-doc for genphy_loopback_no_speed() does not match the
> code.
> 
> --
> 
> net: phy: ncn26000: Support for loopback
> 
> 
> [Severity: Medium]
> Can ncn26000_config_aneg() quietly take the PHY back out of loopback? It
> writes the whole BMCR and does not keep BMCR_LOOPBACK:


Agree on the comment. But falls into bug fix, because It is an existing code. To fix it, we have to start in stable branch.
I wouldn't fix part of this.


> 
> drivers/net/phy/ncn26000.c:ncn26000_config_aneg() {
> ...
> // bring up the link
> return phy_write(phydev, MII_BMCR, NCN26000_BCMR_LINK_CTRL_BIT);
> }
>