[PATCH 08/11] wifi: mt76: mt7925: validate temperature response length
From: Jiale Yao
Date: Mon Oct 19 2026 - 22:49:22 EST
The temperature query removes a fixed prefix and TLV header and then
reads the event without validating the response length. A truncated
firmware response can cause an out-of-bounds read.
Require the prefix, TLV header, and complete temperature event before
pulling the skb.
Fixes: 396e41a74a88 ("wifi: mt76: mt7925: support temperature sensor")
Signed-off-by: Jiale Yao <yaojiale02@xxxxxxx>
---
drivers/net/wireless/mediatek/mt76/mt7925/mcu.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
index e5cacb12d367..d768002c64c2 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
@@ -1037,6 +1037,10 @@ int mt7925_mcu_get_temperature(struct mt792x_phy *phy)
&req, sizeof(req), true, &skb);
if (ret)
return ret;
+ if (skb->len < 4 + sizeof(struct tlv) + sizeof(*evt)) {
+ dev_kfree_skb(skb);
+ return -EINVAL;
+ }
skb_pull(skb, 4 + sizeof(struct tlv));
evt = (struct mt7925_thermal_evt *)skb->data;
--
2.34.1