Re: [PATCH v5 1/8] dt-bindings: interrupt-controller: Add support for Realtek DHC SoCs

[Krzysztof Kozlowski]

On Mon, Oct 19, 2026 at 12:06:46AM +0800, Yu-Chun Lin wrote:
> +properties:
> +  compatible:
> +    enum:
> +      - realtek,rtd1319-intc-iso
> +      - realtek,rtd1319-intc-misc
> +      - realtek,rtd1319d-intc-iso
> +      - realtek,rtd1319d-intc-misc
> +      - realtek,rtd1619b-intc-iso
> +      - realtek,rtd1619b-intc-misc
> +      - realtek,rtd1625-intc-iso
> +      - realtek,rtd1625-intc-isom
> +      - realtek,rtd1625-intc-misc
> +
> +  interrupt-controller: true
> +
> +  '#address-cells':
> +    const: 0
> +
> +  interrupts:
> +    minItems: 1
> +    maxItems: 4
> +    description:
> +      Contains the GIC SPI interrupts mapped to the external interrupt lines.
> +
> +  "#interrupt-cells":

Do not mix style of qotes.

> +    description:
> +      Specifies the number of cells in an interrupt specifier.
> +      For realtek,rtd1625-intc-misc, the first cell specifies the interrupt
> +      bank and the second cell specifies the interrupt ID within that bank.
> +      Other variants use one cell to specify the interrupt ID.

Missing constraints, e.g. enum.

> +
> +required:
> +  - compatible
> +  - interrupt-controller
> +  - '#interrupt-cells'
> +  - '#address-cells'
> +  - interrupts
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - realtek,rtd1319-intc-iso
> +    then:
> +      properties:
> +        interrupts:
> +          items:
> +            - description: Miscellaneous interrupts
> +            - description: RTC interrupt
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - realtek,rtd1319d-intc-iso
> +            - realtek,rtd1619b-intc-iso
> +    then:
> +      properties:
> +        interrupts:
> +          items:
> +            - description: Miscellaneous interrupts
> +            - description: Watchdog interrupt
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - realtek,rtd1319-intc-misc
> +    then:
> +      properties:
> +        interrupts:
> +          items:
> +            - description: Miscellaneous interrupts
> +            - description: Watchdog interrupt
> +            - description: Uart1 interrupt
> +            - description: Uart2 interrupt
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - realtek,rtd1319d-intc-misc
> +            - realtek,rtd1619b-intc-misc
> +    then:
> +      properties:
> +        interrupts:
> +          items:
> +            - description: Miscellaneous interrupts
> +            - description: Uart1 interrupt
> +            - description: Uart2 interrupt
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - realtek,rtd1625-intc-iso
> +    then:
> +      properties:
> +        interrupts:
> +          items:
> +            - description: Miscellaneous interrupts
> +            - description: Uart9 interrupt
> +            - description: RTC interrupt

RTC should be second

> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - realtek,rtd1625-intc-isom
> +    then:
> +      properties:
> +        interrupts:
> +          items:
> +            - description: Miscellaneous interrupts
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - realtek,rtd1625-intc-misc
> +    then:
> +      properties:
> +        interrupts:
> +          items:
> +            - description: Miscellaneous interrupts
> +            - description: Uart3 interrupts

UART1

> +            - description: Uart1 interrupt

UART2

> +            - description: Uart2 interrupt

UART3

> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - realtek,rtd1625-intc-misc
> +    then:
> +      properties:
> +        "#interrupt-cells":
> +          const: 2
> +    else:
> +      properties:
> +        "#interrupt-cells":
> +          const: 1

Best regards,
Krzysztof