Re: [PATCH 1/2] mm/compaction: skip folios containing hwpoisoned pages

[David Hildenbrand (Arm)]

On 10/11/26 15:14, Huang, Ying wrote:
> Yuanhe Shu <xiangzao@xxxxxxxxxxxxxxxxx> writes:
> 
>> On 9/28/26 20:12, David Hildenbrand wrote:
>>>
>>> Then they should implement it.
>>
>> Agreed, and nothing here replaces copy_mc.  Two things the check adds
>> while that work is pending: on archs without copy_mc the plain copy
>> does not fail, it consumes the poison - the same poison consumption
>> commit 841a8bfcbad9 ("mm: prevent poison consumption when splitting
>> THP") refused to risk on the split path, at your suggestion; and the
>> refusal happens before the copy is attempted at all, while copy_mc
>> recovers only during the read.  The check and copy_mc compose.
>>
> 
> Is it good to implement the trick in copy_mc_user_highpage() and
> copy_mc_highpage() if the macro copy_mc_to_kernel is undefined?

That is indeed better.

-- 
Cheers,

David