Re: [PATCH net-next 1/2] net: pcs: xpcs: re-order xpcs_pre_config() to update after the reset

[Daniel Thompson]

On Sun, Oct 18, 2026 at 01:00:54PM +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 4 potential
> issue(s) to consider.
>
> Critical: 0 · High: 0 · Medium: 3 · Low: 1
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [Medium] This patch adds a generic XPCS soft reset on Wangxun TXGBE
>   parts every time SGMII is configured.
> - [Medium] The patch drops the interface-change check that gated the
>   SGMII reset, while the new comment still says the reset happens on a…

I think some of the other Medium issues are closely related to dropping
the interface-change check... and that it either a mistake in my part

Definitely needs a respin:
pw-bot: cr


> - [Medium] The commit message describes a preparatory reorder that just
>   'hoist[s] the special case logic for SGMII into the parent function',…
> - [Low] The error handling in xpcs_pre_config() now behaves differently,
>   and the commit message does not mention it.


Daniel.