Re: [PATCH v4 10/16] media: dt-bindings: sony,imx678: Add other Starvis 2 family members

[Sakari Ailus]

Hi Dave,

On Thu, Oct 15, 2026 at 04:57:36PM +0100, Dave Stevenson wrote:
> There are multiple members of the Sony Starvis 2 image sensor family
> that have the same hardware requirements as imx678.
> Add them as options to the imx678 binding, rather than duplicating it.
> 
> Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/media/i2c/sony,imx678.yaml | 38 ++++++++++++++++++----
>  1 file changed, 32 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx678.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx678.yaml
> index 098f72544216..027872a134f2 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx678.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx678.yaml
> @@ -5,7 +5,7 @@
>  $id: http://devicetree.org/schemas/media/i2c/sony,imx678.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Sony IMX678 Sensor
> +title: Sony IMX678 and Starvis 2 Sensors
>  
>  maintainers:
>    - Jai Luthra <jai.luthra@xxxxxxxxxxxxxxxx>
> @@ -13,21 +13,47 @@ maintainers:
>  description:
>    Sony IMX678 diagonal 8.86 mm (Type 1/1.8) CMOS active pixel type solid-state
>    image sensor with a square pixel array and 8.40M (3856x2180) effective pixels.

You could rewrap this while at it.

> +  It is part of the Starvis 2 family of sensors.
> +  Other members of the Starvis 2 have the same hardware requirements, and
> +  therefore share this binding.

This paragraph could be rewrapped, too -- the limit is 80 characters per
line.

>  
>  allOf:
>    - $ref: /schemas/media/video-interface-devices.yaml#
>  
>  properties:
>    compatible:
> -    items:
> -      - enum:
> -          - sony,imx678-aamr
> -          - sony,imx678-aaqr
> -      - const: sony,imx678
> +    oneOf:
> +      - items:
> +          - enum:
> +              - sony,imx585-aamj
> +              - sony,imx585-aaqj
> +          - const: sony,imx585
> +      - items:
> +          - enum:
> +              - sony,imx662-aamr
> +              - sony,imx662-aaqr
> +          - const: sony,imx662
> +      - items:
> +          - enum:
> +              - sony,imx675-aamr
> +              - sony,imx675-aaqr
> +          - const: sony,imx675
> +      - items:
> +          - enum:
> +              - sony,imx678-aamr
> +              - sony,imx678-aaqr
> +          - const: sony,imx678
> +      - items:
> +          - enum:
> +              - sony,imx832-amr
> +              - sony,imx832-aqr
> +          - const: sony,imx832

Should we also have a sony,starvis2 compatible? Just wondering.

The driver isn't generic still as it requires sensor specific information
to be passed to it. CCS solves this with CCS static data (via firmware
loading mechanism) so there are no driver changes even if the capability
and limit information can't be obtained from device's registers or the
device requires MSRs.

> +
>      description:
>        The IMX678 sensor exists in a colour variant (IMX678-AAQR) and a mono
>        variant (IMX678-AAMR). The variant-specific compatible describes the
>        exact sensor variant, with the generic IMX678 compatible as a fallback.
> +      The same applies for the other sensors in the family.
>  
>    reg:
>      maxItems: 1
> 

-- 
Regards,

Sakari Ailus