Re: [PATCH v3 10/14] drm/solomon: ssd16xx: Expose session management as plane properties

[Markus Elfring]

…
> +++ b/drivers/gpu/drm/solomon/ssd16xx.c
…
> @@ -1619,6 +1725,8 @@ static void ssd16xx_plane_atomic_update(struct drm_plane *plane,
>  	drm_dbg(&device->drm, "plane_atomic_update: calling fb_dirty rect=(%d,%d)-(%d,%d)\n",
>  		rect.x1, rect.y1, rect.x2, rect.y2);
>  
> +	mutex_lock(&device->lock);
> +
…
@@ -1693,6 +1800,8 @@ static void ssd16xx_plane_atomic_update(struct drm_plane *plane,
>  		device->border_waveform_pending = true;
>  	}
>  
> +	mutex_unlock(&device->lock);
> +
>  	pm_runtime_mark_last_busy(device->drm.dev);
…

How do you think about to apply scoped lock guards?
https://elixir.bootlin.com/linux/v7.3/source/include/linux/cleanup.h#L332-L335

Regards,
Markus