Re: [PATCH v7 1/3] drm/panel: Use devm_mipi_dsi_attach in BOE panels

[Luca Ceresoli]

Hello Osama,

On Mon Sep 21, 2026 at 3:17 PM CEST, Osama Abdelkader wrote:
> Use the managed MIPI DSI attach and panel add helpers in BOE panel drivers
> and drop the corresponding manual detach and panel remove calls from
> remove paths.
>
> Signed-off-by: Osama Abdelkader <osama.abdelkader@xxxxxxxxx>

...

> diff --git a/drivers/gpu/drm/panel/panel-boe-himax8279d.c b/drivers/gpu/drm/panel/panel-boe-himax8279d.c
> index 4a8560b4b899..facf37bd1c14 100644
> --- a/drivers/gpu/drm/panel/panel-boe-himax8279d.c
> +++ b/drivers/gpu/drm/panel/panel-boe-himax8279d.c
> @@ -851,9 +851,7 @@ static int panel_add(struct panel_info *pinfo)

As a separate series, renaming the functions in this file to name the
driver name would be nice, e.g. from panel_probe() to
boe_himax8279d_probe(). Would be much more grep-friendly.

> diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> index 150dff3ab6c3..cf9f15fae272 100644
> --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> @@ -1736,9 +1736,7 @@ static int boe_panel_add(struct boe_panel *boe)

Same for this driver.

This patch looks good:
Reviewed-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com