Re: [PATCH 2/2] arm64: dts: qcom: shikra: Enable CDSP & Modem cooling

[Konrad Dybcio]

On 9/11/26 7:03 AM, Dipa Ramesh Mantre wrote:
> Unlike the CPU, the CDSP/Modem does not throttle its speed automatically
> when it reaches high temperatures in shikra.
> 
> Set up CDSP/Modem cooling by throttling the CDSP and modem when they
> reach 115°C using the QMI TMD cooling device framework.
> 
> Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@xxxxxxxxxxxxxxxx>
> ---

[...]

> -				nsp-critical {
> +				nsp_alert1: nsp-alert1 {
>  					temperature = <115000>;
> +					hysteresis = <5000>;
> +					type = "passive";
> +				};

No "hot" points? And no throttling at all until 115?

> +
> +				nsp-critical {
> +					temperature = <118000>;
>  					hysteresis = <0>;
>  					type = "critical";
>  				};
>  			};
> +
> +			cooling-maps {
> +				map0 {
> +					trip = <&nsp_alert1>;
> +					cooling-device = <&remoteproc_cdsp QCOM_TMD_CDSP_SW
> +							 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;

Please align the arguments so that we have:

<&foo bar
 FOO BAR>

instead of

<&foo bar
FOO BAR>


Konrad