Re: [PATCH net 2/2] selftests: net: check veth carrier after changing channel counts

[Xia Yan]

Hi,

I checked the two selftest findings on the Sashiko dashboard:
https://netdev-ai.bots.linux.dev/sashiko/#/patchset/8081

The LOWER_UP coverage issue is valid. The test detects the original bug
through the running endpoint in the mixed up/down cases, but cannot read
the down endpoint's raw carrier state through IFF_LOWER_UP.

For v2, I have limited the assertions and commit description to LOWER_UP
on running endpoints and dropped the down/down cases. The test targets
the incorrect LOWER_UP reported by an up endpoint whose peer is down;
it does not claim to verify the raw carrier bit on a down endpoint.

I also changed the veth creation failure path to use log_test_skip().
An injected creation failure after a failed case confirmed that the SKIP
line no longer repeats the earlier error message and that the aggregate
failure is preserved.

I reran the revised test under the existing unpatched and patched UML
kernels: the four mixed up/down cases fail before the fix, and all six
cases pass after it. The driver diff is unchanged.

Thanks,
Xia Yan