Re: [PATCH v2 6/6] gpiolib: let the character device free its IRQs first on chip removal
From: Adrian Ambrozewicz
Date: Tue Oct 20 2026 - 09:04:50 EST
On Mon, Oct 19, 2026 at 05:00:13PM +0800, Kent Gibson wrote:
> This way is clearer given gc->to_irq() can return 0 - the <= condition
> there is purely because of its possible return values.
> Setting irq to either 0 or an negative error code, rather than just returning
> on the spot, are both more confusing and pointless.
Agreed. For v3 I plan to go back to that form (return when there is no
->to_irq(), then return on irq <= 0) and to drop the comment in
lineevent_free(), as you suggested.
Andy, shout if you still prefer the merged check.
Thanks for the review.
Adrian