Re: [PATCH net-next v8 3/3] net: stmmac: dwxgmac2: add XGMAC timestamp interrupt support

From: Paolo Abeni

Date: Tue Oct 20 2026 - 09:33:09 EST


On 10/14/26 14:49, zhu xin wrote:
Hi,

Thanks for the review.

On Wed, Oct 14, 2026 at 12:03 PM <netdev-bot+sashiko@xxxxxxxxxx> wrote:

Thank you for your contribution! Sashiko AI review found 5 potential
issue(s) to consider.

Critical: 0 · High: 0 · Medium: 5 · Low: 0

If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).

- [Medium] The commit message says dwxgmac2_timestamp_interrupt() cannot
race a FIFO flush because "PTP_ACR_ATSFC is only ever set while…

Valid and will be fixed in the respin.

- [Medium] In stmmac_enable(PTP_CLK_REQ_EXTTS), the 'already enabled'
-EBUSY check is dead.

Valid and will be fixed in the respin.

Please note that:
- patch 1/3 has more comments, and likely more relevant.
- net-next is currently closed, you will have to wait for the end of
the merge window for the next iteration.

/P