Re: [PATCH v6 06/18] fs/resctrl: Introduce kernel mode states for resctrl

[Babu Moger]

Hi Reinette,

On 10/19/26 11:18, Reinette Chatre wrote:
> Hi Babu,
>
> On 10/16/26 8:10 AM, Moger, Babu wrote:
> > On 10/15/2026 9:37 AM, Reinette Chatre wrote:
> > > On 10/1/26 8:10 AM, Babu Moger wrote:
>
> > > > +/**
> > > > + * struct resctrl_kmode_cfg - Kernel mode configuration
> > > > + * @kmode_sup:    Bitmap of supported kernel modes.
> > > > + * @kmode_cur:    Currently selected kernel mode.
> > >
> > > Adding this comment during a second pass ... please consider later motivations
> > > about naming of these fields. This field is introduced as "kmode_cur" but when
> > > considering the language used in rest of series "active" seems more appropriate.
> > >
> > > @kmode_sup could also just be @supported (the "kmode" is redundant).
> >
> > Sure. Will change kmode_cur to "current".
>
> Please do not use "current" as it is generally used to represent the
> current running task.
>
> Why do you find "active" not appropriate? The text usually refers to it as
> the "active". Consider the resctrl.rst text that reads "When the mode is
> not active ...", changelogs refer to it as the "active" mode, user messages
> refer to it as the "active" mode, the functions are named
> rdtgroup_kmode_global_activate()/rdtgroup_kmode_global_deactivate().

Yea. My bad. Sorry for the confusion.

@supported and @active looks good.

Thanks
Babu