Re: [PATCH v3 2/7] docs: submitting-patches: say which commit a Fixes tag names
From: Thorsten Leemhuis
Date: Tue Oct 20 2026 - 10:33:48 EST
On 10/20/26 15:54, Sasha Levin wrote:
> On Sat, Oct 17, 2026 at 10:07:36AM +0200, Thorsten Leemhuis wrote:
>
> So v4 will have:
Great, thx!
The following might be nitpicking, so feel free to silently ignore it:
> Name the commit that introduced the bug. When using ``git blame`` to
> find it, do not settle on a commit that only moved the code. If a later
> commit exposed an older bug, add a Fixes: tag for that commit too. If
> the same bug was introduced separately by more than one commit, add a> Fixes: tag for each.
This jumps from "change that caused a bug", to "change that exposed a
bug", back to "changes that caused a bug". The order I suggested avoided
that.
Independently: I'm not a native speaker, but "If the same bug..." to me
sounded like it refers to something specific (especially if the "exposed
an older bug" in the sentence before remains). Maybe just use "If one
bug..." instead to avoid that.
> Do not add tags for commits that are only
> suspected. The Fixes: tags tell the stable team which trees need the
> fix: those that contain one of the tagged commits. Trees that contain
> none of them do not need it.
Maybe it's just me, but I'd remove the last sentence, as that feels like
it kinda implied by the one right before it.
Ciao, THorsten