Re: [PATCH bpf-next 06/16] libbpf: Relocate arena percpu access instructions

[bot+bpf-ci]

> libbpf: Relocate arena percpu access instructions

TL;DR: Nit only: the new BPF_PSEUDO_ARENA_PERCPU comment in bpf.h (and its
tools/ copy) starts text on the "/*" line instead of BPF comment style, though
it may match neighbouring comments.

> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> index 6f70db7515dd..9e5fa52c9bc2 100644
> --- a/include/uapi/linux/bpf.h
> +++ b/include/uapi/linux/bpf.h
> @@ -1418,6 +1418,19 @@ enum {
>   */
>  #define BPF_PSEUDO_FUNC		4
>  
> +/* insn[0].src_reg:  BPF_PSEUDO_ARENA_PERCPU
                ^^^^

This isn't a bug, but the text of this new multi-line comment starts on the
same line as the opening "/*".  Should it use the BPF comment style, with
"/*" on a line of its own?

/*
 * insn[0].src_reg:  BPF_PSEUDO_ARENA_PERCPU
 * insn[0].imm:      map fd
 * ...
 */

The same comment is duplicated in tools/include/uapi/linux/bpf.h.  The
neighbouring BPF_PSEUDO_* comments in these headers use the old format, so
this may have been done to keep that table consistent.

> + * insn[0].imm:      map fd
> + * insn[1].imm:      offset of the value in cpu 0's chunk, including the chunk's
> + *                   offset in the arena and the value's offset in the chunk
> + * insn[0].off:      0
> + * insn[1].off:      0
> + * ldimm64 rewrite:  address of the value in cpu 0's chunk. The JIT adds
> + *                   smp_processor_id() * chunk_sz to step it into the
> + *                   running cpu's replica
> + * verifier type:    PTR_TO_ARENA
> + */
> +#define BPF_PSEUDO_ARENA_PERCPU	7

[ ... ]


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/39434884362